Allow more parameters for BO #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
robert1826
reviewed
May 10, 2019
| bounds = {f'x{i}': (0., 1.) for i in range(self.dimension)} | ||
| seed = np.random.randint(2**32, dtype=np.uint32) | ||
| self._bo = BayesianOptimization(self._fake_function, bounds, random_state=np.random.RandomState(seed)) | ||
| if self._parameters.gp_parameters is not None: | ||
| self._bo.set_gp_parameters(**self._parameters.gp_parameters) |
There was a problem hiding this comment.
this actually should be self._bo.set_gp_params(**self._parameters.gp_parameters)
There was a problem hiding this comment.
Thanks, I was a bit too fast with it sorry. It should now be solved
Btw, don't hesitate to create a new issue (or PR) for this kind of comment, I nearly did not see it in my emails :s
There was a problem hiding this comment.
Thanks, I was a bit too fast with it sorry. It should now be solved
Btw, don't hesitate to create a new issue (or PR) for this kind of comment, I nearly did not see it in my emails :s
I really don't feel like making a new PR for just correcting a very small typo :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Closes #189
How Has This Been Tested (if it applies)
Checklist