Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pip package for omnivore #18

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

miguelmartin75
Copy link
Contributor

  • adds a setup.py and move source code to omnivore folder

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2022
Copy link
Contributor

@mannatsingh mannatsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @miguelmartin75 !

Have you verified that the tutorial / instructions don't break after this change? Is the goal to upload a package to pypi or just to make this pip installable but not push to pypi?

setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@miguelmartin75
Copy link
Contributor Author

The goal of this PR was just for it to be pip installable. I'll get on those changes.

@miguelmartin75
Copy link
Contributor Author

Tested with:

conda create -n omni_test python=3.10
conda activate omni_test
pip install .

Test the notebook

pip install jupyter
python3 -m ipykernel install --user --name omni_test_kernel
jupyter notebook

Comment out the installation of

# !{sys.executable} -m pip install einops pytorchvideo timm -q

Run the notebook and see that it works as expected & it does.

Copy link
Contributor

@mannatsingh mannatsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks @miguelmartin75

@mannatsingh mannatsingh merged commit e213050 into facebookresearch:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants