-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create pip package for omnivore #18
Conversation
miguelmartin75
commented
Apr 11, 2022
- adds a setup.py and move source code to omnivore folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @miguelmartin75 !
Have you verified that the tutorial / instructions don't break after this change? Is the goal to upload a package to pypi or just to make this pip installable but not push to pypi?
The goal of this PR was just for it to be pip installable. I'll get on those changes. |
Tested with:
Test the notebook
Comment out the installation of
Run the notebook and see that it works as expected & it does. |
c0ce756
to
dd9680c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Thanks @miguelmartin75