-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLRM-comms benchmark doesn't have device attribute #12
Comments
@Sergei-Lebedev Thanks for reporting this. You're right, |
kingchc
added a commit
to kingchc/param-1
that referenced
this issue
Nov 3, 2020
Summary: Add a quick workaround of device selection for DLRM benchmark, which only support cuda now. Fix facebookresearch#12 Differential Revision: D24690816 fbshipit-source-id: 8ea2f86a166d8f7c3e3f1a49db5fa52ad6a17408
@Sergei-Lebedev could you try #15 and see if it fixes the issue for you? |
@kingchc yes, it solves the issue, thanks for a quick fix! |
Fixed for me as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PyTorchNCCLBackend expects to have device attribute in commsParams (6e571fa). This is not the case for DLRM benchmark because first it doesn't have such parameter and second it passes dictionary to PyTorchNCCLBackend.
The text was updated successfully, but these errors were encountered: