Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #10

Closed
wants to merge 1 commit into from
Closed

Update README.md #10

wants to merge 1 commit into from

Conversation

naghshineh
Copy link

Proposing minor changes to README.

@naghshineh naghshineh closed this Oct 8, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2020
shz0116
shz0116 reviewed Oct 9, 2020
View reviewed changes
Copy link

@shz0116 shz0116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But should we make the changes from fbcode instead of github directly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shz0116 shz0116 shz0116 left review comments

@amirstar amirstar Awaiting requested review from amirstar

@kingchc kingchc Awaiting requested review from kingchc

@srinivas212 srinivas212 Awaiting requested review from srinivas212

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naghshineh @shz0116 @facebook-github-bot