Support benchmarking UCC backend through PyTorch in PARAM-Comms #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Update `--backend` argument to accept `ucc` as a valid option - utilize `PyTorchNCCLBackend` for calling collectives UCC PG - move `--backend` option to a common option for all comms benchs - use generic name `PyTorchDistBackend` instead of `PyTorchNCCLBackend` to support NCCL, UCC, MPI, and Gloo backends Differential Revision: D24433491 fbshipit-source-id: 6e80d9c1cfac809ca239561a5d9e93cd22b4c885
kingchc
requested review from
amirstar,
naghshineh,
shz0116 and
srinivas212
as code owners
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24433491 |
|
This pull request has been merged in fa32c86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update
--backendargument to acceptuccas a valid optionPyTorchNCCLBackendfor calling collectives UCC PG--backendoption to a common option for all comms benchsPyTorchDistBackendinstead ofPyTorchNCCLBackendto support NCCL, UCC, MPI, and Gloo backendsDifferential Revision: D24433491