update trace replay mode for post analysis #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingchc
requested review from
amirstar,
naghshineh,
shz0116 and
srinivas212
as code owners
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26730965 |
kingchc
force-pushed
the
export-D26730965
branch
from
45c7e4b
to
7274549
Compare
kingchc
added a commit
to kingchc/param-1
that referenced
this pull request
Mar 11, 2021
Summary: Pull Request resolved: facebookresearch#20 - Output new traces with sequence number and latency for post analysis (one file per rank since there could be skew due to imbalanced workloads) - Remove extra barrier in non-blocking mode - add option `--allow-list` to specified desired collectives to be replayed and ignore the rest in the trace - cleaner summary output in the end (move to logging.info) - Add workaround to correctly complete UCC collectives in non-blocking mode Differential Revision: D26730965 fbshipit-source-id: efc0102bc4b46bb50afcf42e2ceead13a38c9dea
kingchc
force-pushed
the
export-D26730965
branch
from
7274549
to
f2835f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26730965 |
kingchc
added a commit
to kingchc/param-1
that referenced
this pull request
Mar 12, 2021
Summary: Pull Request resolved: facebookresearch#20 - Output new traces with sequence number and latency for post analysis (one file per rank since there could be skew due to imbalanced workloads) - Remove extra barrier in non-blocking mode - add option `--allow-list` to specified desired collectives to be replayed and ignore the rest in the trace - cleaner summary output in the end (move to logging.info) - Add workaround to correctly complete UCC collectives in non-blocking mode Differential Revision: D26730965 fbshipit-source-id: 951e295a695310f2a3883572f4eabe0a8e1d604b
kingchc
force-pushed
the
export-D26730965
branch
from
f2835f8
to
e9aeaf8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26730965 |
Summary: Pull Request resolved: facebookresearch#20 - Output new traces with sequence number and latency for post analysis (one file per rank since there could be skew due to imbalanced workloads) - Remove extra barrier in non-blocking mode - add option `--allow-list`/`--allow-ops` to specified desired collectives to be replayed and ignore the rest in the trace - cleaner summary output in the end (move to logging.info) - Add workaround to correctly complete UCC collectives in non-blocking mode Differential Revision: D26730965 fbshipit-source-id: 7d0ee80903245bed3390b42e3f8072e27bafb7e2
kingchc
force-pushed
the
export-D26730965
branch
from
e9aeaf8
to
34eb9e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26730965 |
|
This pull request has been merged in 4a9e7ee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
--allow-listto specified desired collectives to be replayed and ignore the rest in the traceDifferential Revision: D26730965