fix collective overlap test #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
requested review from
amirstar,
kingchc,
naghshineh and
srinivas212
as code owners
facebook-github-bot
added
the
CLA Signed
|
@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kingchc
approved these changes
Aug 12, 2021
|
closing this as this should have been fixed in 7e654fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
Traceback (most recent call last):
File param/train/comms/pt/comms.py", line 1050, in
main()
File "param/train/comms/pt/comms.py", line 1046, in main
collBenchObj.runBench(comms_world_info, commsParams)
File "param/train/comms/pt/comms.py", line 998, in runBench
backendObj.benchmark_comms()
File "param/train/comms/pt/pytorch_dist_backend.py", line 520, in benchmark_comms
self.commsParams.benchTime(index, self.commsParams, self)
File "param/train/comms/pt/comms.py", line 965, in benchTime
commsParams, allSizes, tensorList, results
File "param/train/comms/pt/comms.py", line 714, in reportBenchTime
str("%d" % (results[curSize]["num_elements_pair"])),
KeyError: 'num_elements_pair'