Improve compute benchmark framework test coverage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add a new test for a simple benchmark object creation by json - get default benchmark options - load json into benchmark config - init a Benchmark object - assert a Benchmark object is created, run_options is not empty in the object, bench_config.bench_config of the benchmark object is not empty This test try to improve test coverage involve config.py, config_util.py, benchmark.py Reviewed By: louisfeng Differential Revision: D37490539 fbshipit-source-id: 5a292fcba97d000d94a250701a4871f22ce87ff8
louisfeng
requested review from
srinivas212,
naghshineh and
kingchc
as code owners
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37490539 |
|
This has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new test for a simple benchmark object creation by json
This test try to improve test coverage involve config.py, config_util.py, benchmark.py
Reviewed By: louisfeng
Differential Revision: D37490539