move fbgemm_gpu import #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40325678 |
Summary: Pull Request resolved: facebookresearch#66 fbgemm_gpu's bench_utils would set the global log level to DEBUG, and add noise to PARAM runs. The global logging config cannot be easily overwritten unless using new flag (`force`) introduced by python3.8. Now import fbgemm_gpu on-demand only when it is required and it won't overwrite the log level and format set by PARAM. fix facebookresearch#65 Differential Revision: D40325678 fbshipit-source-id: 0757329357ea003c1d81997d1fa1487734517258
kingchc
force-pushed
the
export-D40325678
branch
from
059ecbb
to
a7d8d5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40325678 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fbgemm_gpu's bench_utils would set the global log level to DEBUG, and add exta noise to PARAM. This cannot be easily overritten unless using new flag (
force) introduced by python3.8.Now import fbgemm_gpu on-demand only when it is required and it won't overrit the log level and formate set by PARAM.
fix #65
Differential Revision: D40325678