Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readTrace code #71

Closed
wants to merge 1 commit into from
Closed

Improve readTrace code #71

wants to merge 1 commit into from

Conversation

Pavani-Panakanti
Copy link

Summary:

  • As we have different file formats one for eg and one for older trace format..the changes to support both these formats can be improved
  • We are storing trace file as older format..trying to retrieve rank from trace file name and correcting the file name for eg
  • Instead of this we should just store input trace path and generate trace path per rank based on if its eg format or older format which is much cleaner
  • This was we can use this from other places too to read the eg traces without tying it with older format

Differential Revision: D44468989

@facebook-github-bot
Improve readTrace code
9713634 
Summary:
* As we have different file formats one for eg and one for older trace format..the changes to support both these formats can be improved
* We are storing trace file as older format..trying to retrieve rank from trace file name and correcting the file name for eg
* Instead of this we should just store input trace path and generate trace path per rank based on if its eg format or older format which is much cleaner
* This was we can use this from other places too to read the eg traces without tying it with older format

Differential Revision: D44468989

fbshipit-source-id: d059278b5b83ed5b6c8dd1de364e31b24600576d
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44468989

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d731a9b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas212 srinivas212 Awaiting requested review from srinivas212

@kingchc kingchc Awaiting requested review from kingchc kingchc is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pavani-Panakanti @facebook-github-bot