This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Match any exception type for Tensor indexing API #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The tensor indexing API relies on exceptions when a prop name cannot be converted to an int via `std::stoi`. After upgrading to Expo 46, it causes a runtime error (`std::exception&`), which doesn't get caught with the current `catch`. The change broadens the `catch` to match any exception (`catch (...)`), which fixes the issue. The reasons are not clear, but it's assumed to be a compiler flag change. We continue to investigate, but in the meantime, this change unblock anyone who is facing the same issue Reviewed By: justinhaaheim Differential Revision: D39148492 fbshipit-source-id: 766d716d7991415110262d600d94268441e858af
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request was exported from Phabricator. Differential Revision: D39148492 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The tensor indexing API relies on exceptions when a prop name cannot be converted to an int via
std::stoi.After upgrading to Expo 46, it causes a runtime error (
std::exception&), which doesn't get caught with the currentcatch. The change broadens thecatchto match any exception (catch (...)), which fixes the issue.The reasons are not clear, but it's assumed to be a compiler flag change. We continue to investigate, but in the meantime, this change unblock anyone who is facing the same issue
Reviewed By: justinhaaheim
Differential Revision: D39148492