This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Replace unit-tests on LMModel and FLLanguageModelingTask by LiteLMModel and FLLiteLMTask #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20651264 |
…el and FLLiteLMTask (facebookresearch#1296) Summary: Pull Request resolved: facebookresearch#1296 Previously, fl_language_model_test.py covers unit-tests on LMModel by comparing LMTask and FLLMTask. We will ship LiteLMModel instead of LMModel, hence the unit-tests should be using LiteLMModel, LiteLMTask, and FLLiteLMTask instead. One caveat: we need to import LiteLMTask from fb/tasks.py, however, the import section in fb/tasks.py misses tons of dependencies (I guess no unit-tests was ran on tasks.py?), hence I have to replicate LiteLMTask. Reviewed By: kmalik22 Differential Revision: D20651264 fbshipit-source-id: d4843efdea6e4dbc5ffd97963a275ac87337580b
psuzhanhy
force-pushed
the
export-D20651264
branch
from
9228dc1
to
e3ef6dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20651264 |
|
This pull request has been merged in 68882be. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, fl_language_model_test.py covers unit-tests on LMModel by comparing LMTask and FLLMTask.
We will ship LiteLMModel instead of LMModel, hence the unit-tests should be using LiteLMModel, LiteLMTask, and FLLiteLMTask instead.
One caveat: we need to import LiteLMTask from fb/tasks.py, however, the import section in fb/tasks.py misses tons of dependencies (I guess no unit-tests was ran on tasks.py?), hence I have to replicate LiteLMTask.
Reviewed By: kmalik22
Differential Revision: D20651264