Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Replace unit-tests on LMModel and FLLanguageModelingTask by LiteLMModel and FLLiteLMTask #1296

Closed
wants to merge 1 commit into from
Closed

Replace unit-tests on LMModel and FLLanguageModelingTask by LiteLMModel and FLLiteLMTask #1296

wants to merge 1 commit into from

Commits on Mar 26, 2020

  1. Replace unit-tests on LMModel and FLLanguageModelingTask by LiteLMMod… 

    …el and FLLiteLMTask (facebookresearch#1296)

Summary:
Pull Request resolved: facebookresearch#1296

Previously, fl_language_model_test.py covers unit-tests on LMModel by comparing LMTask and FLLMTask.

We will ship LiteLMModel instead of LMModel, hence the unit-tests should be using LiteLMModel, LiteLMTask, and FLLiteLMTask instead.

One caveat: we need to import LiteLMTask from fb/tasks.py, however, the import section in fb/tasks.py misses tons of dependencies (I guess no unit-tests was ran on tasks.py?), hence I have to replicate LiteLMTask.

Reviewed By: kmalik22

Differential Revision: D20651264

fbshipit-source-id: d4843efdea6e4dbc5ffd97963a275ac87337580b
    @psuzhanhy @facebook-github-bot
    psuzhanhy authored and facebook-github-bot committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    e3ef6dc View commit details
    Browse the repository at this point in the history