Handle header has not newline or space after OFF. #665
Conversation
|
Hi @yadiszzz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Lots of off files from ModelNet40 dataset don't have the newline or space after 'OFF' at the beginning of the file.
|
CLA signed. waiting for bot to update. |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@bottler has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks for this! Although you created a new test, it doesn't pass, and the existing tests don't either. I'll sort this out. |
Summary: Allow a line like `OFF10 10 10` as the start of an OFF file. Such things apparently occur in ModelNet40. This resolves #663. Pull Request resolved: #665 Test Plan: New test Reviewed By: nikhilaravi Differential Revision: D28180006 Pulled By: bottler fbshipit-source-id: 7f474c6a262e32da012217e09f76e8672a7f0278
It resolves #663.