Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

[FeatureRequest] Use PyBullet Client ID to enable multiple pybullet instances #1

Closed
mees opened this issue Dec 18, 2020 · 2 comments
Closed
Labels
good first issue Good for newcomers

Comments

@mees
Copy link
Contributor

mees commented Dec 18, 2020

Currently the Sensor class doesn't accept a cid as input parameter [0]. For cases where one wants to have multiple pybullet instances / threads, using the cid would be a simple way to allow it.

[0] https://github.com/facebookresearch/tacto/blob/master/tacto/sensor.py#L52

@poweic
Copy link
Contributor

poweic commented Dec 23, 2020

Hi @mees,

Thank you for submitting the first feature request!

Yes, adding a cid would be a quick and simple way to allow users to have multiple pybullet instances. Would you like to submit a pull request? If not, I can work on this.

@mees
Copy link
Contributor Author

mees commented Dec 23, 2020

Hi @poweic,
I just created a PR, let me know if its ok.

@poweic poweic added the good first issue Good for newcomers label Dec 24, 2020
@poweic poweic closed this as completed Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants