Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed convergence check error in DCEM with negative error metrics. #510

Merged
merged 1 commit into from
May 3, 2023
Merged

Fixed convergence check error in DCEM with negative error metrics. #510

merged 1 commit into from
May 3, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented May 3, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 3, 2023
@luisenp luisenp mentioned this pull request May 3, 2023
Open
mhmukadam
mhmukadam approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@luisenp luisenp merged commit 656aa84 into main May 3, 2023
@luisenp luisenp deleted the lep.fix_dcem_neg_err branch May 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamos bamos bamos approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

@dishank-b dishank-b Awaiting requested review from dishank-b

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luisenp @bamos @mhmukadam @facebook-github-bot