Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing inference dependencies #496

Closed
lunixbochs opened this issue Jan 24, 2020 · 3 comments
Closed

reducing inference dependencies #496

lunixbochs opened this issue Jan 24, 2020 · 3 comments
Assignees

Comments

@lunixbochs
Copy link
Contributor

  • inference depends on a cblas library for SpeechUtils
    It looks like fbgemm can do a gemm on its own (it's even in the name), but wav2letter libraries won't build without another cblas library present, due to the SpeechUtils cblasGemm function

  • inference depends on gflags, which isn't mentioned in the wiki

git clone https://github.com/gflags/gflags.git
cd gflags
cmake .
make && make install
@avidov
Copy link
Contributor

avidov commented Jan 25, 2020

  • inference depends on a cblas library for SpeechUtils
    It looks like fbgemm can do a gemm on its own (it's even in the name), but wav2letter libraries won't build without another cblas library present, due to the SpeechUtils cblasGemm function

This is a good point. Currently inference reuses libraries/feature/FeatureParams.h which uses cblas, but we should use whatever backend inference is set to use (currently only supports FBGEMM but soon will support others for mobile platforms). I marked it as desired enhancement for now.

inference depends on gflags, which isn't mentioned in the wiki

Inference examples using gflags. CMake searches for it and download it if not found, so the wiki does not ask to install manually.

@lunixbochs
Copy link
Contributor Author

CMake searches for it and download it if not found, so the wiki does not ask to install manually.

This doesn't seem to happen for me:

-- Could NOT find GFlags (missing: GFLAGS_INCLUDE_DIR GFLAGS_LIBRARY) 
CMake Error at inference/CMakeLists.txt:43 (message):
  GFLAGS not found

When running from wav2letter/build on a Mac

KENLM_ROOT_DIR=~/build/kenlm/build cmake .. -DW2L_BUILD_LIBRARIES_ONLY=ON -DW2L_BUILD_INFERENCE=ON -DW2L_LIBRARIES_USE_CUDA=OFF

@lunixbochs
Copy link
Contributor Author

lunixbochs commented Feb 22, 2020

as fbgemm is already a dependency, maybe it's simpler to just always use a function from that for featurization instead of playing cblas hot potato?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants