Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications improvements for Windows #401

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Notifications improvements for Windows #401

merged 5 commits into from
Jul 21, 2020

Conversation

facelessuser
Copy link
Owner

  • Notifications will not show up in notification panel as we keep an
    taskbar icon present at all times now.
  • Multiple instances will share the same taskbar icon. If the originator
    destroys the taskbar icon, on the next notification of existing
    instances, a taskbar icon will be recreated.

@facelessuser
Notifications improvements for Windows
9579640 
- Notifications will not show up in notification panel as we keep an
  taskbar icon present at all times now.
- Multiple instances will share the same taskbar icon. If the originator
  destroys the taskbar icon, on the next notification of existing
  instances, a taskbar icon will be recreated.
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: data Related to data. C: gui Related to the GUI. C: notifications Related to notifications. C: settings Related to settings managment. C: source Related to source code. labels Jul 21, 2020
@facelessuser facelessuser mentioned this pull request Jul 21, 2020
Open
@gir-bot gir-bot added the C: docs Related to documentation. label Jul 21, 2020
@facelessuser
Copy link
Owner Author

Codecov is broken for us and not working, we have to figure this out....

@gir-bot gir-bot added the C: infrastructure Related to project infrastructure. label Jul 21, 2020
@facelessuser
Copy link
Owner Author

Seems there is a codecov outage so we'll wait until this is resolved. I was having issues yesterday, so I assumed something changed. We'll give it time and see what happens.

@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Jul 21, 2020
@facelessuser facelessuser merged commit 08b8630 into master Jul 21, 2020
@facelessuser facelessuser deleted the enhancement/notify branch July 21, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: data Related to data. C: docs Related to documentation. C: gui Related to the GUI. C: infrastructure Related to project infrastructure. C: notifications Related to notifications. C: settings Related to settings managment. C: source Related to source code. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@facelessuser @gir-bot