Fix terminal-notifier issues

- Fix sender issue and stop blocking on calls

CHANGES.md

@@ -1,3 +1,10 @@
+# SubNotify 1.4.2
+
+> Released June 4, 2017
+
+- **FIX**: Use official ST icon for messages in Linux and Growl.
+- **FIX**: Fix blocking issue with `terminal-notifier`.
+
 # SubNotify 1.4.1
 
 > Released June 2, 2017

lib/notify/notify_osx.py

@@ -106,14 +106,11 @@ def notify_osx_call(title, message, sound, fallback):
             params += ["-message", message]
         if title is not None:
             params += ["-subtitle", title]
-        if Options.icon is not None:
-            params += ['-appIcon', Options.icon]
-        # if Options.sender is not None:
-        #     params += ["-sender", Options.sender]
-        #     params += ["-activate", Options.sender]
+        if Options.sender is not None:
+            params += ["-sender", Options.sender]
         if sound:
             params += ["-sound", "Glass"]
-        subprocess.call(params)
+        subprocess.Popen(params)
 
         # if sound:
         #     # Play sound if desired

sub_notify.py

@@ -114,9 +114,8 @@ def enable_notifications(notice=False):
 def get_icon_files():
     """Get icon files."""
 
-    platform = sublime.platform()
     settings = get_settings()
-    png_name = 'SublimeText@2x.png' if settings.get('large_icons', platform in ['osx'. 'linux']) else 'SublimeText.png'
+    png_name = 'SublimeText@2x.png' if settings.get('large_icons',True) else 'SublimeText.png'
     graphics = os.path.join(sublime.packages_path(), "SubNotify", "graphics")
     png_path = os.path.join(graphics, png_name)
     ico_path = os.path.join(graphics, "SublimeBubble.ico")