Switch appendChild to replaceBefore in hmr script #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's the same as appendChild |
|
@ScriptedAlchemy is this one of interest? would really like to see this feature be solved :) |
|
fix tests and ill merge @alonalon |
|
@ScriptedAlchemy resolved conflicts with old test, but can't find a equivalent test in the new setup |
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to keep the link tags on the same place in the dom as there where from the beginning. This is to keep the order of css assets.
e.g. if you have a inline style tag last in your document that overwrite css from linked stylesheets, after HMR have compiled and inserted new links to the stylesheets, the the inline styles are still last and the import order for the css rules are still correct