Skip to content

Commit

Permalink
Fix for segfault in DataLoadCSV destructor (#784)
Browse files Browse the repository at this point in the history
- Change order of deletion for dialogs.
- First delete child dialog `_dateTime_dialog` then parent
`_dialog`.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
  • Loading branch information
MichaelOrlov committed Feb 8, 2023
1 parent 2ab35b1 commit 721be84
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plotjuggler_plugins/DataLoadCSV/dataload_csv.cpp
Expand Up @@ -140,8 +140,8 @@ DataLoadCSV::DataLoadCSV()
DataLoadCSV::~DataLoadCSV()
{
delete _ui;
delete _dialog;
delete _dateTime_dialog;
delete _dialog;
}

const std::vector<const char*>& DataLoadCSV::compatibleFileExtensions() const
Expand Down

0 comments on commit 721be84

Please sign in to comment.