Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest code crashes with old layout files #934

Closed
ssys-zdavis opened this issue Feb 8, 2024 · 1 comment
Closed

Latest code crashes with old layout files #934

ssys-zdavis opened this issue Feb 8, 2024 · 1 comment

Comments

@ssys-zdavis
Copy link

ssys-zdavis commented Feb 8, 2024

Problem description

A recent change:
36cebbf#r138442242

broke loading of old layouts that have a "Scale/Offset" transform applied.

Describe the problem and the expected behavior. Use screenshots or a video, if applicable.

Answer these questions (or I will ignore your issue)

  1. Describe your platform / Operative System and the version of PlotJuggler you are using.

  2. Compile and try the latest version in the main branch and check if the problem persists.

  3. Check if the problem can be reproduced using the dummy data created by the command line argument "-t" or one of the files in the folder "datasamples".

  4. If it can't be reproduced with the dummy data, please share the CSV file or the rosbag that can be used to reproduce the problem.

  5. Linux and Windows with latest main

  6. It does (see 1)

  7. Yes. Run with -t and open the attached layout file

broken_layout.xml.txt

@facontidavide
Copy link
Owner

Thanks for reporting... I did not think about that problem of back compatibility.

I will fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants