Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt improvements for packaging support #9

Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jun 26, 2024

Hi! This PR proposes a few minor tweaks to the CMakeLists.txt to simplify potential packaging as a Conan (a recipe draft) or Vcpkg package.

The changes:

  • Add basic install() commands for the standalone C++ library.
  • Make CMAKE_POSITION_INDEPENDENT_CODE configurable.
  • Allow SHARED builds.
  • Set cxx_std_17 property instead of set(CMAKE_CXX_STANDARD 17) to make it easier to override the standard, if necessary.
  • Make USING_ROS2 an explicit option.
  • Add an EXTERNAL_FASTCDR option.
  • Add missing target_link_libraries() for rapidjson.

@valgur
Copy link
Contributor Author

valgur commented Jun 26, 2024

Also, for external use, would a rosx_introspection::rosx_introspection CMake target be ok or would you prefer a non-namespaced rosx_introspection?

@facontidavide facontidavide merged commit bfa9473 into facontidavide:master Jun 27, 2024
3 checks passed
@facontidavide
Copy link
Owner

looks good to me. Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants