Foo 1527 more unit tests #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## issue942 #999 +/- ##
==============================================
+ Coverage 74.06% 74.13% +0.06%
+ Complexity 17 5 -12
==============================================
Files 212 208 -4
Lines 4342 4260 -82
Branches 295 295
==============================================
- Hits 3216 3158 -58
+ Misses 1021 993 -28
- Partials 105 109 +4 |
…st into FOO-1527-more-unit-tests
uweschaefer
requested changes
Aug 26, 2020
factcast-factus/src/main/java/org/factcast/factus/applier/DefaultProjector.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/main/java/org/factcast/factus/applier/DefaultProjector.java
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/DefaultFactusTest.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/DefaultFactusTest.java
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/DefaultFactusTest.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/applier/DefaultProjectorTest.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/lock/LockedTestManagedProjection.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/lock/LockedTestAggregate.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/lock/LockedTestManagedProjection.java
Outdated
Show resolved
Hide resolved
factcast-factus/src/test/java/org/factcast/factus/lock/LockedTestSnapshotProjection.java
Outdated
Show resolved
Hide resolved
BernhardBln
commented
Aug 27, 2020
| // projection, | ||
| // the lock would be broken | ||
| assertThat(locked.specs()) | ||
| .isEqualTo(specs); |
| eventSerializer, | ||
| new DuplicateHandlerProjection())) | ||
| // ASSERT | ||
| .isInstanceOf(UnsupportedOperationException.class) |
There was a problem hiding this comment.
Something fancy like UnsatisfiedLinkError or LayerInstantiationException? :P
I agree, I suggest to create your own exception type though
|
all resolved, adding more tiny tests |
uweschaefer
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.