Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin): error msg references assetsPath instead of assets #30

Merged
merged 2 commits into from
Jun 2, 2022
Merged

fix(plugin): error msg references assetsPath instead of assets #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7a3c19
fix(plugin): error msg references assetsPath instead of assets
dnnsjrng Jun 2, 2022
54b3b9d
docs: rename mixManifest -> mix headline and fix an typo related to a…
dnnsjrng Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const USER_OPTIONS = {

## Shortcodes

### `mixManifest`
### `mix`

If you've generated a mixManifest and add the path to it to the `USER_OPTIONS` then it's possible to add the non hashed files to a template e.g.:

Expand All @@ -157,10 +157,10 @@ Please provide a path relative so that `userOptions.assets.root + userOptions.ba

### `asset_path`

This is a simple helper shortcode to make your defined asset path `userOptions.base` available in a template:
This is a simple helper shortcode to make your defined asset path `userOptions.assets.base` available in a template:

```twig
{{ asset_path() }} --> will result in userOptions.base like "assets"
{{ asset_path() }} --> will result in /userOptions.assets.base like "/assets"
```

### `image`
Expand Down
2 changes: 1 addition & 1 deletion lib/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const handleErrors = (userOptions) => {

if (userOptions.mixManifest && !userOptions.assets?.base) {
errors.push(
"userOptions.mixManifest requires userOptions.assetsPath.base to be defined."
"userOptions.mixManifest requires userOptions.assets.base to be defined."
);
}

Expand Down