Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: msmtp logging #34

Merged
merged 20 commits into from
Jun 15, 2021
Merged

Bugfix: msmtp logging #34

merged 20 commits into from
Jun 15, 2021

Conversation

papey
Copy link
Contributor

@papey papey commented Oct 27, 2020

Fixes a bug with msmtp logging by redirecting msmtp log to stdout and wraps the things into a dash script redirecting msmtp stdout to pid 1 stdout.

Testing procedure is listed below :

make 7.1-cli
docker container run --rm --name=msmtp-logging-test -t -i -e MAILS_DOMAIN="mail.example.com" -e MAILS_USER=user@example.com -e MAILS_HOST="mail.example.com" -e MAILS_FROM="from@example.com" -e MAILS_TOKEN="pass" bearstech/php-cli:7.1 bash
bash -c "echo "test" | sendmail dest@example.com

@papey papey requested a review from beavis69 October 27, 2020 14:19
@papey papey force-pushed the bugfix/msmtp-logging branch 2 times, most recently from de1c453 to 0f04a44 Compare October 29, 2020 13:16
@papey
Copy link
Contributor Author

papey commented Oct 29, 2020

@athoune merge if LGTY 👍

@papey papey requested a review from athoune November 4, 2020 14:44
@papey
Copy link
Contributor Author

papey commented Nov 4, 2020

More tests added, now can get logs from outside (ie docker daemon)

@papey papey force-pushed the bugfix/msmtp-logging branch 5 times, most recently from 0658a4c to 1e41ce5 Compare November 5, 2020 20:43
@athoune athoune merged commit 3e7a6bd into master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants