Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer parsing is broken #112

Closed
yura415 opened this issue Sep 2, 2016 · 4 comments
Closed

Developer parsing is broken #112

yura415 opened this issue Sep 2, 2016 · 4 comments

Comments

@yura415
Copy link
Contributor

yura415 commented Sep 2, 2016

No description provided.

@facundoolano
Copy link
Owner

Can you elaborate?

@yura415
Copy link
Contributor Author

yura415 commented Sep 2, 2016

Sry.. Google apeear to have recently change their developer page url to https://play.google.com/store/apps/dev?id= instead of https://play.google.com/store/apps/developer?id=.
As you can see here https://github.com/facundoolano/google-play-scraper/blob/dev/lib/developer.js#L15 url is still in old format so none of the requests come with status 200.

If you'd open https://play.google.com/store/apps/developer?id=6695914693084197974 and https://play.google.com/store/apps/dev?id=6695914693084197974 you can see the difference.

@facundoolano
Copy link
Owner

Thanks, I'll try to fix it today.

@facundoolano
Copy link
Owner

@yura415 I'm checking this now and it looks like the /developer page is still working. The thing is that endpoint works with the developer name as the id (rather than a number like the /dev page). Using your example:

https://play.google.com/store/apps/developer?id=Intellijoy%20Educational%20Games%20for%20Kids

Using the module:

> gplay.developer({devId: 'Intellijoy Educational Games for Kids'}).then(console.log)
Promise { <pending> }
> [ { url: 'https://play.google.com/store/apps/details?id=com.intellijoy.android.reading.free',
    appId: 'com.intellijoy.android.reading.free',
    title: 'Kids Learn to Read (Lite)',
    summary: 'A must-have sequel to our best-selling Kids ABC Phonics',
    developer: 'Intellijoy Educational Games for Kids',
    icon: '//lh3.googleusercontent.com/p19nyn88_sJrHuPCnAltYEn1EXUoko7YKOM97i0I6bLz8F6zK-C9FC3H6Pmwf3ESy_A=w340',
    score: 4,
    price: '0',
    free: true },
    ...
]

I'm closing this and opening a different issue so we start supporting both types of ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants