-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a generic entity revert controller. #17
Conversation
class RevisionRevertForm extends ConfirmFormBase { | ||
|
||
/** | ||
* The node revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the node revision :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
We now have a base class |
* @return \Drupal\Core\Entity\RevisionableInterface | ||
* The prepared revision ready to be stored. | ||
*/ | ||
protected function prepareRevertedRevision(RevisionableInterface $revision) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepareRevertedRevision feels wrong if the revision hasn't been reverted yet.
Perhaps just prepareRevision() then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about prepareRevisionRevert ?
e4f0998
to
a094d14
Compare
Provide a generic entity revert controller.
No description provided.