Remove 'duplicate' revision log textbox on entity form. #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #34
This approach does create a requirement to extend
Drupal\entity\Revision\RevisionableContentEntityBase
, though since these classes appear to be designed to work together to address revision UI use cases, and that's the case in the test, this appears appropriate. A less blunt method would be to test whether$form['revision_log_message']
is present, but that doesn't feel very specific and is probably bad DX.