port_remove_user_role-2471645-6.patch #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Provides a 'Remove user role' action. | ||
| * | ||
| * @action( |
|
Thanks, this is really looking good. Just some nitpicks as you can see from my comments. Would be great if you could fix those :). Thanks! |
| @@ -0,0 +1,76 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
There should be a @file comment of the beginning of each file. Please check other Action plugins for reference.
|
I have continued work on this over at PR 214 #214 |
|
OK, let's continue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a patch for https://www.drupal.org/node/2471645
Added RulesUserIntegrationTestTrait again - might be doubled now, because a.milkovsky uploaded before, but it wasn't merged yet...
Please review - it's my first unittest.... ;-)