Port "Remove user role" action to D8 #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| */ | ||
| class UserRoleRemove extends RulesActionBase | ||
| { |
There was a problem hiding this comment.
opening braces should be on the same line, also elsewhere.
|
Hmm... seems my new version of phpstorm needs setting up again ;) Couple of points: fubhy noted on original PR "Please add a short description "Provides mocked user objects for the testRemoveExistingRole test." or somtehing like that." but I couldn't see where, let me know if this is still valid. Also katzilla noted test coverage may not be enough, let me know if more tests needed. |
| class UserRoleRemoveTest extends RulesEntityIntegrationTestBase { | ||
|
|
||
| use RulesUserIntegrationTestTrait; | ||
| /** |
There was a problem hiding this comment.
There should be a newline before the comment.
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picking up from PR 182 - tidy & reroll so far