Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observer.py imports typing.Protocol which is not in Python 3.7 #369

Closed
yhay81 opened this issue Jan 24, 2021 · 2 comments
Closed

observer.py imports typing.Protocol which is not in Python 3.7 #369

yhay81 opened this issue Jan 24, 2021 · 2 comments
Labels

Comments

@yhay81
Copy link
Contributor

yhay81 commented Jan 24, 2021

I got an error when I run tox
E ImportError: cannot import name 'Protocol' from 'typing' (/Users/yhay81/.pyenv/versions/3.7.9/lib/python3.7/typing.py)

It is because observer.py import typing.Progocol and typing.Progocol is new in Python version 3.8.
https://docs.python.org/3/library/typing.html#typing.Protocol
(It is from #345)

I think this is one of a solution.

  • Drop testing 3.7 in tox.
  • Write notation comment in observer.py which says it is new feature of 3.8

I can make PR if this is okay.

@yhay81
Copy link
Contributor Author

yhay81 commented Jan 26, 2021

I dropped testing 3.7 in tox: #372
If it is okay that this repo do not support 3.7, I think this issue can be closed.

@faif
Copy link
Owner

faif commented Jan 26, 2021

Yeah, that's fine. In general it's good to keep up with the latest minor version + 1 or more minor older versions, but we don't need to support all of them.

@faif faif closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants