Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

house keeping update #372

Merged
merged 1 commit into from
Jan 25, 2021
Merged

house keeping update #372

merged 1 commit into from
Jan 25, 2021

Conversation

yhay81
Copy link
Contributor

@yhay81 yhay81 commented Jan 24, 2021

Several small updates

In addition, I think it is helpful for contributors if there is info of below.
From root files, I found the way to start developing this repo is

git clone git@github.com:faif/python-patterns.git
cd python-patterns
python -m venv venv
pip install --upgrade pip
make pyupgrade

And after coding, check it by this.

make pylinter
tox

@codecov-io
Copy link

codecov-io commented Jan 24, 2021

Codecov Report

Merging #372 (b548b45) into master (28e8b5f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   30.43%   30.38%   -0.05%     
==========================================
  Files          39       39              
  Lines        1275     1277       +2     
==========================================
  Hits          388      388              
- Misses        887      889       +2     
Impacted Files Coverage Δ
patterns/behavioral/iterator.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e8b5f...b548b45. Read the comment docs.

@faif faif merged commit 4fcbf1b into faif:master Jan 25, 2021
@yhay81 yhay81 deleted the house_keeping branch January 26, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants