Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate version specific scripts #287

Merged
merged 4 commits into from
Mar 8, 2019

Conversation

gyermolenko
Copy link
Contributor

@faif
This PR is related to our discussion in #208

#208 (comment)

maybe it's better to split those files to Python 2/3 versions until the Python 2 EOL

There are 4 scripts with metaclasses (chain_of_responsibility, registry, blackboard, flyweight).
I modified 2/4 here to get your feedback. If you are ok with these changes - please let me know. I'll finish work in this or separate PR.

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #287 into master will decrease coverage by 3.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   70.21%   66.85%   -3.36%     
==========================================
  Files          56       58       +2     
  Lines        2058     2091      +33     
==========================================
- Hits         1445     1398      -47     
- Misses        613      693      +80
Impacted Files Coverage Δ
tests/test_outputs.py 100% <ø> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py2.py 0% <0%> (ø)
patterns/behavioral/registry__py2.py 0% <0%> (ø)
...atterns/behavioral/chain_of_responsibility__py3.py 0% <0%> (ø)
patterns/behavioral/registry__py3.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4292a34...02b653a. Read the comment docs.

@faif faif merged commit 423fe9d into faif:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants