Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script runner and hints at the top #312

Merged
merged 1 commit into from Nov 7, 2019

Conversation

gyermolenko
Copy link
Contributor

@gyermolenko gyermolenko commented Nov 7, 2019

related to #277

The main thing here is removal of run_all.sh.
As I understand it was used to

  • run all available scripts
  • coverage

These things are covered by tests and doctests.

@codecov-io
Copy link

Codecov Report

Merging #312 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #312     +/-   ##
=========================================
- Coverage   36.68%   36.49%   -0.2%     
=========================================
  Files          38       38             
  Lines        1341     1307     -34     
=========================================
- Hits          492      477     -15     
+ Misses        849      830     -19
Impacted Files Coverage Δ
patterns/structural/mvc.py 0% <ø> (ø) ⬆️
patterns/creational/factory.py 0% <ø> (ø) ⬆️
patterns/behavioral/iterator.py 0% <ø> (ø) ⬆️
patterns/behavioral/mediator.py 0% <ø> (ø) ⬆️
patterns/behavioral/state.py 97.61% <ø> (-0.06%) ⬇️
patterns/structural/front_controller.py 0% <ø> (ø) ⬆️
patterns/structural/flyweight.py 0% <ø> (ø) ⬆️
patterns/behavioral/command.py 87.5% <ø> (-0.74%) ⬇️
patterns/creational/builder.py 78.94% <ø> (-0.54%) ⬇️
patterns/behavioral/specification.py 83.6% <ø> (-0.27%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ec43a...506ab8b. Read the comment docs.

@faif faif merged commit 1af2089 into faif:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants