BF: Invert expression on actionstop in bsd-ipfw.conf to ensure exit s…

…tatus 0 on success. Closes gh-343
fail2ban · Aug 30, 2013 · 7cc3e8a · 7cc3e8a
1 parent d5684a0
commit 7cc3e8a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -36,6 +36,10 @@ ver. 0.8.11 (2013/XX/XXX) - loves-unittests
   Rolf Fokkens
    * action.d/dshield.conf and complain.conf -- reorder mailx arguements.
 	   https://bugzilla.redhat.com/show_bug.cgi?id=998020
+  John Doe (ache)
+   * action.d/bsd-ipfw.conf - invert actionstop logic to make exist status 0.
+     closes gh-343.
+
 - New Features:
   Daniel Black & ykimon
    * filter.d/3proxy.conf -- filter added
@@ -45,6 +49,7 @@ ver. 0.8.11 (2013/XX/XXX) - loves-unittests
    * add date expression for apache-2.4 - milliseconds
   Christophe Carles & Daniel Black
    * filter.d/perdition.conf -- filter added
+
 - Enhancements:
   François Boulogne and Frédéric
    * filter.d/lighttpd - auth regexs for lighttpd-1.4.31

diff --git a/THANKS b/THANKS
@@ -5,6 +5,7 @@ know (preferably send a pull request on github with the "fix") and you
 will be added
 
 Adrien Clerc
+ache
 Andrey G. Grozin
 Arturo 'Buanzo' Busleiman
 Axel Thimm

diff --git a/config/action.d/bsd-ipfw.conf b/config/action.d/bsd-ipfw.conf
@@ -21,7 +21,7 @@ actionstart = ipfw show | fgrep -q 'table(<table>)' || ( ipfw show | awk 'BEGIN
 # Notes.:  command executed once at the end of Fail2Ban
 # Values:  CMD
 #
-actionstop =  [ -f <startstatefile> ] && ( read num < "<startstatefile>" <br> ipfw -q delete $num <br> rm "<startstatefile>" )
+actionstop =  [ ! -f <startstatefile> ] || ( read num < "<startstatefile>" <br> ipfw -q delete $num <br> rm "<startstatefile>" )
 
 
 # Option:  actioncheck