Impossible to specify multiple same actions within a jail with different names

[yarikoptic]

e.g.

[asterisk]

enabled  = true
filter   = asterisk
action   = iptables-multiport[name=asterisk-udp, port="5060,5061", protocol=udp]
           iptables-multiport[name=asterisk-tcp, port="5060,5061", protocol=tcp]
           sendmail-whois[name=Asterisk, dest=you@example.com, sender=fail2ban@example.com]
logpath  = /var/log/asterisk/messages
maxretry = 10

would result only in asterisk-tcp chain setup -- it is due to actions taking the 'name' of the jail. Simple patch

diff --git a/client/jailreader.py b/client/jailreader.py
index f66dc01..247216f 100644
--- a/client/jailreader.py
+++ b/client/jailreader.py
@@ -87,7 +87,9 @@ class JailReader(ConfigReader):
                        for act in self.__opts["action"].split('\n'):
                                try:
                                        splitAct = JailReader.splitAction(act)
-                                   action = ActionReader(splitAct, self.__name)
+                                 # YOH: action takes name specified in options if available
+                                 action = ActionReader(splitAct,
+                                                                           splitAct[1].get('name', self.__name))
                                        ret = action.read()
                                        if ret:
                                                action.getOptions(self.__opts)

is insufficient since it brakes logic somewhere in jails.py (I believe) which relies on action name to correspond to jail name. So more TODO (may be action name could be jail_name:action_name_option)?

[generalfault]

Wanted to give a +1 to this... it's rather important if you have a central syslog server that distrubutes bans across a cluster... here is a typical jail section:

[ssh-iptables]
enabled  = true
filter   = sshd
action   = iptables[name=SSH, port=ssh, protocol=tcp]
           rban[rhost=server4.cluster.com, ruleset=rban-ssh]
           rban[rhost=server5.cluster.com, ruleset=rban-ssh]
           rban[rhost=server7.cluster.com, ruleset=rban-ssh]
           rban[rhost=server8.cluster.com, ruleset=rban-ssh]
           rban[rhost=server9.cluster.com, ruleset=rban-ssh]
logpath  = /var/log/secure
maxretry = 5

as is is now, we have to copy the rban action to rban1, rban2, rban3.... etc

[combro2k]

+1 I want to use multiple sendmail-whois-lines to send a mail to blocklist.de and myself.
Now it only matches the last one there 👎

[kwirk]

Had a look at this as I recently tweaked this area of the code for the filter [Init] sections, therefore was sort of familiar with this code.

kwirk/fail2ban@fail2ban:0.9...kwirk:multiaction

[yarikoptic]

that it's awesome @kwirk
I think this one is worth for master (I could cheery pick if necessary)
please send pr for consistency :-)

[kwirk]

@yarikoptic Will do. My battery is about to die on my laptop, so wont be today...

[yarikoptic]

So we resolved this with PR #189