Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-server and -client stall (stop responding/returning) if external command stalls #60

Closed
yarikoptic opened this issue Jul 6, 2012 · 3 comments

Comments

@yarikoptic
Copy link
Member

Original report: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=410077

if external command (like mail) doesn't return but stalls, -server
would stall as well and would stop responding to -client requests like
status or stop, which makes it necessary to manually kill that command
and/or fail2ban.

@kwirk
Copy link
Contributor

kwirk commented Apr 25, 2013

Now that python2.3 is no longer supported, it should be quite easy to replace the os.system calls with python's subprocess1 module. Can then use poll2 method to check if the command has exited, and timeout after a set/configurable period.

@yarikoptic
Copy link
Member Author

Good idea
Although I would prefer to introduce this to 0.9 first

Steven Hiscocks notifications@github.com wrote:

Now that python2.3 is no longer supported, it should be quite easy to
replace the os.system calls with python's subprocess1 module. Can
then use poll2 method to check if the command has exited, and
timeout after a set/configurable period.


Reply to this email directly or view it on GitHub:
#60 (comment)

Sent from a phone which beats iPhone.

@yarikoptic
Copy link
Member Author

Closed by PR #190, thanks to @kwirk's work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants