Skip to content

actions.d/bsd-ipfw.conf startstatefile errors in 0.9.0 #713

Closed
ache opened this Issue May 2, 2014 · 1 comment

2 participants

@ache
ache commented May 2, 2014

bsd-ipfw.conf have

startstatefile = /var/run/fail2ban/ipfw-started-table_<table>

<table> is not expanded here perhaps because of

# Values: STRING

instead of

# Values: CMD

for startstatefile causing lots of on-stop errors like that:

2014-05-02 17:46:39,615 fail2ban.server.action[74335]: ERROR [ ! -f /var/run/fail2ban/ipfw-started-table_<table>
] || ( read num < "/var/run/fail2ban/ipfw-started-table_<table>"
ipfw -q delete $num
rm "/var/run/fail2ban/ipfw-started-table_<table>" ) -- stderr: 'cannot open table: No such file or directory\ncann
ot open /var/run/fail2ban/ipfw-started-table_<table>: No such file or directory\nipfw: missing rule specification\n
rm: /var/run/fail2ban/ipfw-started-table_<table>: No such file or directory\n'

@kwirk kwirk added a commit to kwirk/fail2ban that referenced this issue May 3, 2014
@kwirk kwirk BF: Tags not fully recursively substituted
Note: recursive check ignored for "matches", as tags would be escaped,
and hence shouldn't match "<%s>" as "<ip>" would become "\<ip\>". This
therefore maintains advantage of delayed call for {ip,jail,}matches.

Fixes gh-713
b3266ba
@kwirk
Fail2Ban member
kwirk commented May 3, 2014

@ache Thanks for reporting this bug. I've been able to replicate. Should be fixed once #715 is reviewed and hopefully merged 😄

@kwirk kwirk added this to the 0.9.1 milestone May 7, 2014
@yarikoptic yarikoptic closed this in #715 May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.