bug-fix: set correct bash completion options for fail2ban-regex #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fail2ban-regex does not have the same parameters like fail2ban-client or fail2ban-server
| _init_completion || return | ||
| _init_completion || return | ||
|
|
||
| if [[ "$1" == *"fail2ban-regex" ]] && [[ "$cur" == "-"* ]];then |
There was a problem hiding this comment.
with this change it doesn't suggest any file for the first argument <LOG> and would only complete options (but that also did it before). So what gets fixed really? ;)
PS sorry for the delay
There was a problem hiding this comment.
tbh i don't know anymore (too long ago).
Surely it made sense back then => just close the PR ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail2ban-regex does not have the same parameters like fail2ban-client or fail2ban-server.
The bash-completion script offered the same options for all of them though.