Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compression and count from logrotate #1312

Merged
merged 1 commit into from Feb 10, 2016

Conversation

sbraz
Copy link
Contributor

@sbraz sbraz commented Jan 28, 2016

Initially reported at https://bugs.gentoo.org/show_bug.cgi?id=549856
As the reporter mentioned, the count parameter means logs are deleted regardless of the global logrotate config; the compression setting should also inherit the global defaults.

@yarikoptic
Copy link
Member

sounds sensible to me (I will let this issue age a bit to hear other @fail2ban/developers and @fail2ban/contributors )... I wonder though why so many logrotate configs on my debian system has those specified explicitly...

@szepeviktor
Copy link
Member

Sometime it is critical to find a 4 months old mail server log line or PayPal IPN in Apache's log.

@yarikoptic
Copy link
Member

On Thu, 28 Jan 2016, Viktor Szépe wrote:

Sometime it is critical to find a 4 months old mail server log line or
PayPal IPN in Apache's log.

sure, but the question is more of either Fail2Ban should inherit
settings from the main logrotate configuration or have its own "opinion"
on the defaults ;)

@szepeviktor
Copy link
Member

Let's say the max bantime is 1 week ([recidive]). Logrotate's default is 4×weeks, so I would merge this PR.

@yarikoptic
Copy link
Member

merged manually to resolve the conflict and pushed. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants