add jail.conf and other misc fixes #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The commands are executed through a system shell so shell redirection and process control is allowed. The commands should | ||
| return 0 to indicate success which will prevent fail2ban attempting to retry (up to \fBmaxretry\fR times to ban the IP again. | ||
|
|
||
| The following action parameters are in the [defination] section. |
There was a problem hiding this comment.
WTF... can't post a comment -- comes out blank...
s|defination|Definition|g
| ss = os.stat(self.__sock_name) | ||
| self.assertIsNot(stat.S_ISSOCK(ss.st_mode), 0) | ||
|
|
||
| # pid removal is done in server.start |
There was a problem hiding this comment.
I believe the asyncServer.start in server.start is blocking, such that the PID file should only be removed when AsyncServer (and therefore fail2ban) has stopped.
|
ok. think I covered everything. Thanks guys. |
|
I have pushed with some post-merge tune ups. Please checkout master's version on either it is all good ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jail.conf man page + other misc fixes.
If you want me to separate these kind of pull requests just tell me.