Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10 - Execution of actionstart on demand (fixes gh-1741) #1742

Merged
merged 3 commits into from
Mar 29, 2017

Conversation

sebres
Copy link
Contributor

@sebres sebres commented Mar 29, 2017

  • implemented execution of actionstart on demand, if action depends on family (conditional);
  • new action parameter actionstart_on_demand (bool) can be set to prevent/allow starting action on demand (default retrieved automatically, if some conditional parameter param?family=... presents in action properties), see action.d/pf.conf for example;
  • additionally actionstop will be executed only for families previously executing actionstart (starting on demand only)

Closes #1741

…n `family` (closes fail2bangh-1741);

new action parameter "actionstart_on_demand" (bool) can be set to prevent/allow starting action on demand (default retrieved automatically, if some conditional parameter `param?family=...` presents in action properties);
…nfo, but dict was supplied in the test case)
@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage decreased (-0.005%) to 97.091% when pulling ca18270 on sebres:0.10-actionstart-on-demand into 05f5c6e on fail2ban:0.10.

@codecov-io
Copy link

codecov-io commented Mar 29, 2017

Codecov Report

Merging #1742 into 0.10 will increase coverage by 0.05%.
The diff coverage is 98.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##             0.10    #1742      +/-   ##
==========================================
+ Coverage   94.88%   94.93%   +0.05%     
==========================================
  Files          77       77              
  Lines       11912    11951      +39     
  Branches     1842     1858      +16     
==========================================
+ Hits        11303    11346      +43     
+ Misses        345      342       -3     
+ Partials      264      263       -1
Impacted Files Coverage Δ
fail2ban/client/actionreader.py 87.23% <100%> (+2.45%) ⬆️
fail2ban/tests/servertestcase.py 92.85% <100%> (+0.08%) ⬆️
fail2ban/server/action.py 95.46% <97.87%> (+1.65%) ⬆️
fail2ban/server/utils.py 87.8% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f5c6e...daa13eb. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+0.03%) to 97.13% when pulling daa13eb on sebres:0.10-actionstart-on-demand into 05f5c6e on fail2ban:0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants