Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: order config as jail.conf, jail.d/*.conf, jail.local, jail.d/*.loca... #392

Merged
merged 1 commit into from
Oct 14, 2013
Merged

ENH: order config as jail.conf, jail.d/*.conf, jail.local, jail.d/*.loca... #392

merged 1 commit into from
Oct 14, 2013

Conversation

grooverdan
Copy link
Contributor

...l. closes gh-388

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d6d51e3 on grooverdan:config_order into 2d1bd54 on fail2ban:master.

@yarikoptic
Copy link
Member

well... that might brake some installations where people deduced and relied upon current order. But what problem such change would solve? may be we should just document current order?

@grooverdan
Copy link
Contributor Author

The problem to be solved is:

  • provide distro maintainers of fail2ban the ability to overwrite jail.conf without extensively modifying it (like jail.d / fail2ban.d ordering and doco #388) and not worry if the user has created a jail.local file conflicting with it
  • provide distro maintainers of other packages to place in jail.d/x.conf files leaving it to the user to enable them in jail.local or jail.d/x.local
  • make the *.conf files the primary files and then the *.local files as overrides in a more logical way
  • by adding {fail2ban|jail}.d/*.local encourages users to only make local changes to .local files files

This change would break are those where the user has overwritten a jail.local with a jail.d/x.conf file. I'd make the assumption that most users would use one or the other and not overwrite their own config in jail.local with a jail.d/x.conf file.

I think its important to set this logical priority of files before these features are extensively used.

@yarikoptic
Copy link
Member

yeah -- sounds reasonable ;) cheers and thanks

On Thu, 10 Oct 2013, Daniel Black wrote:

The problem to be solved is:

 * provide distro maintainers of fail2ban the ability to overwrite
   jail.conf without extensively modifying it (like [1]#388) and not
   worry if the user has created a jail.local file conflicting with it
 * provide distro maintainers of other packages to place in jail.d/x.conf
   files leaving it to the user to enable them in jail.local or
   jail.d/x.local
 * make the *.conf files the primary files and then the *.local files as
   overrides in a more logical way
 * by adding {fail2ban|jail}.d/*.local encourages users to only make
   local changes to .local files files

Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate, Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

@grooverdan
Copy link
Contributor Author

yeah -- sounds reasonable ;) cheers and thanks

Your welcome. Sound of written this up first.

Needs a changelog entry but I didn't want to add a conflict with so many outstanding pull requests.

Merge?

grooverdan added a commit that referenced this pull request Oct 14, 2013
ENH: order config as jail.conf, jail.d/*.conf, jail.local, jail.d/*.local
@grooverdan grooverdan merged commit 445c6e6 into fail2ban:master Oct 14, 2013
@grooverdan grooverdan deleted the config_order branch October 14, 2013 11:25
@grooverdan grooverdan mentioned this pull request Oct 30, 2013
grooverdan added a commit that referenced this pull request Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants