Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic RESTful 'Clipboard' #272

Merged
merged 6 commits into from
Oct 8, 2020
Merged

generic RESTful 'Clipboard' #272

merged 6 commits into from
Oct 8, 2020

Conversation

RalphSteinhagen
Copy link
Member

generates a REST server that can be supplied with images from a JavaFX application directly or store user-submitted PNG images.

Exports simple web-interface using Javalin.

Special thanks to @tipsy for the great library, superb user-support, and for answering the various questions that led to this initial concept.

This concept will be extended with additional functionalities at a later stage

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #272 into master will decrease coverage by 3.92%.
The diff coverage is 17.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
- Coverage     47.91%   43.99%   -3.93%     
- Complexity     5627     5890     +263     
============================================
  Files           341      367      +26     
  Lines         34834    39794    +4960     
  Branches       5699     6419     +720     
============================================
+ Hits          16690    17506     +816     
- Misses        17104    21237    +4133     
- Partials       1040     1051      +11     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/de/gsi/acc/remote/BasicRestRoles.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/de/gsi/acc/remote/RestCommonThreadPool.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...cc/src/main/java/de/gsi/acc/remote/RestServer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/de/gsi/acc/remote/admin/RestServerAdmin.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/de/gsi/acc/remote/clipboard/Clipboard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/de/gsi/acc/remote/login/LoginController.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...src/main/java/de/gsi/acc/remote/user/RestUser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/de/gsi/acc/remote/user/RestUserHandlerImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/de/gsi/acc/remote/util/CombinedHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/de/gsi/acc/remote/util/MessageBundle.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73479c...1381354. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2020

This pull request introduces 2 alerts when merging 37d0516 into 08727d5 - view on LGTM.com

new alerts:

  • 1 for Container contents are never accessed
  • 1 for Dereferenced variable may be null

N.B. missing null check was false-positive or superfluous check (depending on point-of-view). removed unused queue
N.B. many of remaining are CSS related for which I am a bit uncertain
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 29
           

Complexity increasing per file
==============================
- chartfx-acc/src/main/java/de/gsi/acc/remote/util/CombinedHandler.java  2
- chartfx-dataset/src/main/java/de/gsi/dataset/remote/DataContainer.java  7
- chartfx-acc/src/main/java/de/gsi/acc/remote/RestServer.java  13
- chartfx-acc/src/main/java/de/gsi/acc/remote/user/RestUserHandlerImpl.java  10
- chartfx-dataset/src/test/java/de/gsi/dataset/remote/MimeTypeTests.java  9
- chartfx-dataset/src/test/java/de/gsi/dataset/remote/DataTests.java  1
- chartfx-acc/src/main/java/de/gsi/acc/remote/user/RestUser.java  3
- chartfx-dataset/src/main/java/de/gsi/dataset/remote/MimeType.java  6
- chartfx-acc/src/main/java/de/gsi/acc/remote/BasicRestRoles.java  7
- chartfx-dataset/src/test/java/de/gsi/dataset/remote/DataContainerTests.java  1
- chartfx-dataset/src/main/java/de/gsi/dataset/remote/Data.java  12
- chartfx-acc/src/main/java/de/gsi/acc/remote/admin/RestServerAdmin.java  2
- chartfx-acc/src/main/java/de/gsi/acc/remote/RestCommonThreadPool.java  2
         

See the complete overview on Codacy

<!DOCTYPE html>
<html lang="$msg.get("LOCALE")">
<head>
<title>$title</title>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Avoid inline JavaScript

border-radius: 5px;
min-height: 200px;
max-height: 200px;
height: auto;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, the javalin api looks really neat, too!
👍

@RalphSteinhagen RalphSteinhagen merged commit cf5b1ab into master Oct 8, 2020
@RalphSteinhagen RalphSteinhagen deleted the clipboard_concept branch October 8, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants