Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table view only to chart if really shown #280

Merged
merged 6 commits into from
Oct 23, 2020

Conversation

dedeibel
Copy link
Contributor

  • Mitigates problem of it taking control over the charts size

I talked about it with akrimm, please ask if you want more info.

wirew0rm
wirew0rm previously approved these changes Oct 21, 2020
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Looks good, thanks.
Will be merged as soon as travis runs though.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #280 into master will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
+ Coverage     49.52%   49.80%   +0.28%     
- Complexity     6848     6864      +16     
============================================
  Files           380      380              
  Lines         40057    40065       +8     
  Branches       6419     6420       +1     
============================================
+ Hits          19837    19955     +118     
+ Misses        18824    18706     -118     
- Partials       1396     1404       +8     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/de/gsi/chart/plugins/TableViewer.java 48.32% <100.00%> (+26.15%) 9.00 <5.00> (+5.00)
...hart/plugins/measurements/DataSetMeasurements.java 75.77% <0.00%> (+0.34%) 153.00% <0.00%> (+2.00%)
...hartfx-chart/src/main/java/de/gsi/chart/Chart.java 76.87% <0.00%> (+0.40%) 102.00% <0.00%> (+1.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.97% <0.00%> (+1.43%) 35.00% <0.00%> (+6.00%)
...ava/de/gsi/chart/utils/SimplePerformanceMeter.java 88.70% <0.00%> (+1.61%) 31.00% <0.00%> (ø%)
...src/main/java/de/gsi/chart/ui/HiddenSidesPane.java 86.88% <0.00%> (+3.27%) 27.00% <0.00%> (+1.00%)
...src/main/java/de/gsi/chart/ui/ToolBarFlowPane.java 71.42% <0.00%> (+5.71%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7edb6...ac59c05. Read the comment docs.

@dedeibel dedeibel force-pushed the table-viewer-add-table-only-when-visible branch from 9e40cd5 to ac59c05 Compare October 23, 2020 09:32
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- chartfx-chart/src/test/java/de/gsi/chart/plugins/TableViewerTest.java  1
         

See the complete overview on Codacy

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks also for the nice tests and the patience with the CI :)

@wirew0rm wirew0rm merged commit eb7a286 into master Oct 23, 2020
@wirew0rm wirew0rm deleted the table-viewer-add-table-only-when-visible branch October 23, 2020 11:01
dedeibel pushed a commit that referenced this pull request Jan 26, 2021
- Mouse transparency was set incorrectly after commit eb7a286 (#280)
wirew0rm pushed a commit that referenced this pull request Jan 26, 2021
TableViewer: table cells can now be selected again
- Mouse transparency was set incorrectly after commit eb7a286 (#280)

Authored-by: Benjamin Peter <B.Peter@gsi.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants