Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableViewer: table cells can now be selected again #341

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

dedeibel
Copy link
Contributor

TableViewer: table cells can now be selected again

Added a test for the specific problem.

(sorry)

Benjamin Peter and others added 2 commits January 26, 2021 16:36
…clickable

Restyle TableViewer: table cells can now be selected again
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #341 (acff7bf) into master (fc81f1f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #341      +/-   ##
============================================
+ Coverage     51.74%   51.81%   +0.07%     
- Complexity     7300     7320      +20     
============================================
  Files           394      394              
  Lines         41197    41272      +75     
  Branches       6627     6640      +13     
============================================
+ Hits          21319    21387      +68     
- Misses        18364    18371       +7     
  Partials       1514     1514              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/de/gsi/chart/plugins/TableViewer.java 48.32% <100.00%> (ø) 7.00 <0.00> (-2.00)
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 76.26% <0.00%> (+0.14%) 182.00% <0.00%> (+1.00%)
...main/java/de/gsi/chart/ui/HiddenSidesPaneSkin.java 44.97% <0.00%> (+0.47%) 36.00% <0.00%> (+2.00%)
...in/java/de/gsi/chart/plugins/DataPointTooltip.java 76.08% <0.00%> (+8.19%) 44.00% <0.00%> (+19.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878a4a0...acff7bf. Read the comment docs.

@wirew0rm wirew0rm merged commit 5c642a4 into master Jan 26, 2021
@wirew0rm wirew0rm deleted the fix-table-plugin-not-clickable branch January 26, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants