-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc improvements #578
Merged
Merged
Misc improvements #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
============================================
- Coverage 51.97% 51.55% -0.42%
- Complexity 6401 6438 +37
============================================
Files 363 367 +4
Lines 37028 37553 +525
Branches 6063 6155 +92
============================================
+ Hits 19244 19362 +118
- Misses 16522 16914 +392
- Partials 1262 1277 +15
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Use ControlsFX's fxsampler project to present the samples instead of having to manually use a bunch of buttons.
wirew0rm
force-pushed
the
miscImprovements
branch
from
April 4, 2023 12:05
c498295
to
2abdf8c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various smaller codestyle fixes and janitorial changes.
Only visible change should be using fx-sampler to present the samples in a bit nicer way, but this also does not impact the library itself. The individual samples can still be launched as individual javafx applications (and via the LaunchJFX helper for adding the javafx modules).