Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #578

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Misc improvements #578

merged 10 commits into from
Apr 4, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Apr 4, 2023

Various smaller codestyle fixes and janitorial changes.

Only visible change should be using fx-sampler to present the samples in a bit nicer way, but this also does not impact the library itself. The individual samples can still be launched as individual javafx applications (and via the LaunchJFX helper for adding the javafx modules).

@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 11:06 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 11:06 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 11:06 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 30.41% and project coverage change: -0.42 ⚠️

Comparison is base (8d349d9) 51.97% compared to head (0d259a3) 51.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #578      +/-   ##
============================================
- Coverage     51.97%   51.55%   -0.42%     
- Complexity     6401     6438      +37     
============================================
  Files           363      367       +4     
  Lines         37028    37553     +525     
  Branches       6063     6155      +92     
============================================
+ Hits          19244    19362     +118     
- Misses        16522    16914     +392     
- Partials       1262     1277      +15     
Impacted Files Coverage Δ
...ir_acc/chartfx/axes/spi/AbstractAxisParameter.java 97.63% <ø> (ø)
...fx/renderer/spi/financial/CandleStickRenderer.java 89.24% <ø> (+0.63%) ⬆️
...rtfx/renderer/spi/financial/FootprintRenderer.java 92.40% <ø> (+0.42%) ⬆️
...hartfx/renderer/spi/financial/HighLowRenderer.java 86.00% <ø> (+0.66%) ⬆️
...n/java/io/fair_acc/chartfx/ui/HiddenSidesPane.java 86.88% <ø> (ø)
...n/java/io/fair_acc/chartfx/utils/XYChartUtils.java 0.00% <ø> (ø)
...in/java/io/fair_acc/dataset/spi/DoubleDataSet.java 99.36% <ø> (ø)
...va/io/fair_acc/dataset/spi/DoubleErrorDataSet.java 100.00% <ø> (ø)
...ain/java/io/fair_acc/dataset/spi/FloatDataSet.java 99.37% <ø> (ø)
...io/fair_acc/dataset/spi/MultiDimDoubleDataSet.java 98.98% <ø> (ø)
... and 10 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wirew0rm wirew0rm temporarily deployed to deploy April 4, 2023 11:10 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy April 4, 2023 12:09 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy April 4, 2023 12:09 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:32 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:32 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:32 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage April 4, 2023 12:32 — with GitHub Actions Inactive
@wirew0rm wirew0rm merged commit 5b00d1d into main Apr 4, 2023
6 of 10 checks passed
@wirew0rm wirew0rm deleted the miscImprovements branch April 4, 2023 12:39
@uosis uosis mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant