Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert math and financial samples to fxsampler #593

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Aug 1, 2023

Follow up of #578 where the samples were switched to using controlsfx's sampler. It turned out that the migration missed the math and financial samples.

@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 07:20 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 07:20 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fafb23e) 50.27% compared to head (4d13c6b) 50.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #593   +/-   ##
=========================================
  Coverage     50.27%   50.27%           
  Complexity     6268     6268           
=========================================
  Files           375      375           
  Lines         37531    37531           
  Branches       6143     6143           
=========================================
+ Hits          18867    18869    +2     
  Misses        17414    17414           
+ Partials       1250     1248    -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 08:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 08:33 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 11:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 11:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 1, 2023 11:28 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy August 1, 2023 11:31 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 10:36 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy August 8, 2023 10:40 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy August 8, 2023 10:40 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 9, 2023 07:21 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 7 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wirew0rm wirew0rm temporarily deployed to deploy August 9, 2023 07:24 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy August 9, 2023 07:25 — with GitHub Actions Inactive
@wirew0rm wirew0rm merged commit 7d41fec into main Aug 9, 2023
12 of 13 checks passed
@wirew0rm wirew0rm deleted the fixSampler branch August 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant