Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and notification system #594

Merged
merged 81 commits into from
Aug 8, 2023
Merged

Layout and notification system #594

merged 81 commits into from
Aug 8, 2023

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Aug 2, 2023

Extension on PR #592 that fixes issues #579 and #530. See issues for more information.

@ennerf ennerf temporarily deployed to coverage August 2, 2023 16:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 16:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 16:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 17:00 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 73.56% and project coverage change: -1.11% ⚠️

Comparison is base (5703417) 51.39% compared to head (7ed1331) 50.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #594      +/-   ##
============================================
- Coverage     51.39%   50.28%   -1.11%     
+ Complexity     6416     6273     -143     
============================================
  Files           372      375       +3     
  Lines         37555    37531      -24     
  Branches       6123     6143      +20     
============================================
- Hits          19301    18873     -428     
- Misses        16981    17414     +433     
+ Partials       1273     1244      -29     
Files Changed Coverage Δ
.../java/io/fair_acc/chartfx/axes/spi/LinearAxis.java 0.00% <0.00%> (ø)
.../io/fair_acc/chartfx/axes/spi/LogarithmicAxis.java 0.00% <0.00%> (ø)
...java/io/fair_acc/chartfx/axes/spi/NumericAxis.java 0.00% <0.00%> (ø)
...in/java/io/fair_acc/chartfx/axes/spi/TickMark.java 87.23% <ø> (+3.56%) ⬆️
.../java/io/fair_acc/chartfx/plugins/EditDataSet.java 23.30% <ø> (+0.13%) ⬆️
.../io/fair_acc/chartfx/plugins/UpdateAxisLabels.java 0.00% <0.00%> (ø)
.../main/java/io/fair_acc/chartfx/plugins/Zoomer.java 26.29% <0.00%> (ø)
...artfx/plugins/measurements/SimpleMeasurements.java 32.75% <0.00%> (-56.39%) ⬇️
...cc/chartfx/renderer/spi/MountainRangeRenderer.java 0.00% <0.00%> (ø)
...acc/chartfx/renderer/spi/ReducingLineRenderer.java 0.00% <0.00%> (ø)
... and 70 more

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ennerf ennerf temporarily deployed to deploy August 2, 2023 17:02 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 17:04 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 17:04 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 17:04 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 17:04 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 17:04 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 17:07 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:26 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 18:30 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 18:30 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 18:58 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 19:02 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to deploy August 2, 2023 19:02 — with GitHub Actions Inactive
@ennerf ennerf temporarily deployed to coverage August 2, 2023 22:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm dismissed their stale review August 8, 2023 17:41

The merge-base changed after approval.

@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to coverage August 8, 2023 17:41 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 117 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@wirew0rm wirew0rm temporarily deployed to deploy August 8, 2023 17:45 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to deploy August 8, 2023 17:45 — with GitHub Actions Inactive
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving because resolving the merge conflicts removed the approval, sorry for the noise.

@wirew0rm wirew0rm merged commit fafb23e into main Aug 8, 2023
11 of 13 checks passed
@wirew0rm wirew0rm deleted the ennerf/notify-chart branch August 8, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5pt,5pt] overhaul of (DataSet) event system
2 participants